[PATCH] 2.5: further llseek cleanup (3/3)

Manfred Spraul (manfred@colorfullife.com)
Sat, 16 Feb 2002 23:31:38 +0100

Hi Robert,

I think the pcilynx change is wrong:

> - if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) return
> -EINVAL;
> + if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) {
> + lock_kernel();
^^^^^^ unlock_kernel()?
> + return -EINVAL;
> + }
>
> file->f_pos = newoffs;
^^^^^^^^^^^^^^^^^^^ where is the unlock here?
> return newoffs;

--
	Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/