[PATCH] -- filesystems.c::sys_nfsservctl

[Craig Christophel]

--------------Boundary-00=_BMOHPIKMF7YKQ9ECLLSF
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

Ok guys get ready to flame me....  

	The attached patch removes the lock/unlock in this function.   Now I am 80% 
sure of this one, but would like a word from the kmod maintainer about 
whether request_module needs the BKL or not.   do_nfsservctl already takes 
the BKL inside the function so as long as request_module is safe this pair 
can be removed -- effectively making do_nfsservctl responsible for it's own 
locking scheme.

	So whoever knows for SURE about request_module, please reply.

========NOT A PATCH --- filesystems.c::sys_nfsservctl================
long
asmlinkage sys_nfsservctl(int cmd, void *argp, void *resp)
{
	int ret = -ENOSYS;
	
	lock_kernel();

	if (nfsd_linkage ||
	    (request_module ("nfsd") == 0 && nfsd_linkage))
		ret = nfsd_linkage->do_nfsservctl(cmd, argp, resp);

	unlock_kernel();
	return ret;
}

==================PATCH ATTACHED==========================

--------------Boundary-00=_BMOHPIKMF7YKQ9ECLLSF
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="filesystems-remove-lock_kernel-nfsd.diff"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="filesystems-remove-lock_kernel-nfsd.diff"

===== fs/filesystems.c 1.4 vs edited =====
--- 1.4/fs/filesystems.c	Fri Feb  8 22:10:55 2002
+++ edited/fs/filesystems.c	Wed Feb 13 15:30:20 2002
@@ -22,13 +22,11 @@
 {
 	int ret = -ENOSYS;
 	
-	lock_kernel();
 
 	if (nfsd_linkage ||
 	    (request_module ("nfsd") == 0 && nfsd_linkage))
 		ret = nfsd_linkage->do_nfsservctl(cmd, argp, resp);
 
-	unlock_kernel();
 	return ret;
 }
 EXPORT_SYMBOL(nfsd_linkage);

--------------Boundary-00=_BMOHPIKMF7YKQ9ECLLSF--