Re: small IDE cleanup: void * should not be used unless neccessary

[Vojtech Pavlik]

On Tue, Feb 12, 2002 at 06:02:16PM -0500, Rob Radez wrote:
> 
> On Mon, 11 Feb 2002, Pavel Machek wrote:
> 
> > Hi!
> >
> > This is really easy, please apply. (It will allow me to kill few casts
> > in future).
> > 								Pavel
> >
> > --- linux/include/linux/ide.h	Mon Feb 11 21:15:04 2002
> > +++ linux-dm/include/linux/ide.h	Mon Feb 11 22:36:12 2002
> > @@ -529,7 +531,7 @@
> >
> >  typedef struct hwif_s {
> >  	struct hwif_s	*next;		/* for linked-list in ide_hwgroup_t */
> > -	void		*hwgroup;	/* actually (ide_hwgroup_t *) */
> > +	struct hwgroup_s *hwgroup;	/* actually (ide_hwgroup_t *) */
> >  	ide_ioreg_t	io_ports[IDE_NR_PORTS];	/* task file registers */
> >  	hw_regs_t	hw;		/* Hardware info */
> >  	ide_drive_t	drives[MAX_DRIVES];	/* drive info */
> 
> If you're doing this, would it make sense to get rid of the useless casting
> of the hwgroup member?

Yes, that's also planned.

-- 
Vojtech Pavlik
SuSE Labs