Re: [PATCH] nbd in 2.5.3 does not work, and can cause severe damage when read-write

[Petr Vandrovec]

On Thu, Jan 31, 2002 at 10:21:57PM +0100, Pavel Machek wrote:
> >     to 20 is needed, as otherwise nbd server commits suicide. Maximum request size
> >     should be handshaked during nbd initialization, but currently just use
> >     hardwired 20 sectors, so it will behave like it did in the past.
> 
> But please do not apply this one. Nbd servers should be fixed, and I
> already have fix in cvs. (Besides, its trivial). Just make buffer in
> server 1MB big.
> 
> I do not like idea of handshake.

I do not like breaking backward compatibility when there is no
need for that, but as you will be the target of the complaints...

Linus, this reverts limit for request size from 10KB to unlimited.
Although no released nbd version supports it, it is certainly better to
add support to servers than cripple clients if incompatibility does
not matter.
					Best regards,
						Petr Vandrovec
						[e-mail]

 
diff -urdN linux/drivers/block/nbd.c linux/drivers/block/nbd.c
--- linux/drivers/block/nbd.c	Thu Jan 31 19:00:00 2002
+++ linux/drivers/block/nbd.c	Thu Jan 10 18:15:38 2002
@@ -518,7 +518,6 @@
 	blksize_size[MAJOR_NR] = nbd_blksizes;
 	blk_size[MAJOR_NR] = nbd_sizes;
 	blk_init_queue(BLK_DEFAULT_QUEUE(MAJOR_NR), do_nbd_request, &nbd_lock);
-	blk_queue_max_sectors(BLK_DEFAULT_QUEUE(MAJOR_NR), 20);
 	for (i = 0; i < MAX_NBD; i++) {
 		nbd_dev[i].refcnt = 0;
 		nbd_dev[i].file = NULL;