Re: [PATCH] Fix rocket port driver

Andi Kleen (ak@muc.de)
Thu, 31 Jan 2002 02:24:13 +0100


On Thu, Jan 31, 2002 at 02:16:40AM +0100, Jeff Garzik wrote:
> > @@ -2042,6 +2046,10 @@
> > PCI_DEVICE_ID_RP8M, i, &bus, &device_fn))
> > if(register_PCI(count+boards_found, bus, device_fn))
> > count++;
> > + if(!pcibios_find_device(PCI_VENDOR_ID_RP,
> > + 0x8, i, &bus, &device_fn))
> > + if(register_PCI(count+boards_found, bus, device_fn))
> > + count++;
>
> Would it be possible to beg and plead and convince you to convert this
> driver to the new PCI API?

I can do that, but not tonight.

Linus, Dave, please does that not let stop you from merging my previous
patch anyways until I get to it..

>
> It hasn't been touched in ages AFAICS, and both 2.4 as well as 2.5 would
> greatly benefit from such a [tested] change.

Comtrol has a newer "beta" driver on their ftp site, but it only adds support
for some new hardware features, but doesn't change much otherwise.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/