Re: [patch] [sched] yield speedup, 2.5.3-pre5

Horst von Brand (brand@jupiter.cs.uni-dortmund.de)
Tue, 29 Jan 2002 17:10:57 +0100


Ingo Molnar <mingo@elte.hu> said:
> On Mon, 28 Jan 2002, Martin Josefsson wrote:
>
> > > - spin_unlock_irq(&rq->lock);
> > > + spin_unlock(&rq->lock);
>
> > I'm not an spinlock expert but shouldn't you use spin_unlock_irq()
> > when it was locked with spin_lock_irq() ?
>
> normally yes, but in this case it's an optimization: schedule() will
> disable interrupts within a few cycles, so there is no point in enabling
> irqs for a short amount of time.

And a short comment in the code?

-- 
Horst von Brand			     http://counter.li.org # 22616
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/