Re: [PATCH] 2.5: push BKL out of llseek

[Alexander Viro]

On Tue, 29 Jan 2002, Linus Torvalds wrote:

> 
> On 29 Jan 2002, Robert Love wrote:
> >
> > This patch pushes the BKL out of llseek() and into the individual llseek
> > methods.  For generic_file_llseek, I replaced it with the inode
> > semaphore.
> 
> Thinking about that, that actally sounds like the _right_ thing to do even
> from a correctness standpoint - as llseek() looks at the inode size, so we
> should have that lock anyway.
> 
> So I'd suggest doing the inode semaphore globally, instead of using
> kernel_lock at all.
> 
> Al?

It's OK for regular files and directories, but I'm not sure about devices.

So I'd prefer to do it in two stages - shift BKL into ->llseek() and then
see where it can be dropped/replaced with ->i_sem.