Re: [PATCH] per-cpu areas for 2.5.3-pre6

[Rusty Russell]

In message <[e-mail]> you write:
> Rusty Russell wrote:
> > 
> > This patch introduces the __per_cpu_data tag for data, and the
> > per_cpu() & this_cpu() macros to go with it.
> > 
> > This allows us to get rid of all those special case structures
> > springing up all over the place for CPU-local data.
> 
> Am I missing something? smp_init() is called quite late in
> the boot process, and if any code touches per-cpu data before
> this, it'll get a null pointer deref, won't it?

Yes.  But for a large amount of code it doesn't matter, and most
architectures don't know how many CPUs there are before smp_init().
Of course, we could make it NR_CPUS...

Do you have an example where you want to use this before
smp_boot_cpus()?  If so, we can bite the bullet.  Otherwise I'd prefer
not to waste memory.

BTW, my master plan (well, stolen from Anton and Paulus here) was to
have one register to point to the per-cpu area, and all you need is a
shift down 12 bits, and with 31 to get cpu id.  Bwahahahah! (non-x86
of course).

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.