Re: [PATCH] Radix-tree pagecache for 2.5

[David S. Miller]

   From: [e-mail] (Linus Torvalds)
   Date: Tue, 29 Jan 2002 19:27:43 +0000 (UTC)

   In article <[e-mail]>,
   Christoph Hellwig  <[e-mail]> wrote:
   >I've ported my hacked up version of Momchil Velikov's radix tree
   >radix tree pagecache to 2.5.3-pre{5,6}.
   
   Looks good. 

I like the changes too, but I'd like to see some numbers
as well.

My only concern is that it doesn't handle one particular
case better than the ugly per-hashchain lock version.  When we're
running through a file and the task doing this changes cpus.
In that case we'll get a lock collision and the per-hashchain lock
changes would at least potentially avoid that.

For web serving sizeable files this might matter, but probably
we don't really care.  Probably it doesn't matter and we are limited
to moving one lock over in such an event anyways.