Re: [patch] [sched] yield speedup, 2.5.3-pre5

[Oliver Xymoron]

On Mon, 28 Jan 2002, Ingo Molnar wrote:

> On Mon, 28 Jan 2002, Martin Josefsson wrote:
>
> > > -	spin_unlock_irq(&rq->lock);
> > > +	spin_unlock(&rq->lock);
>
> > I'm not an spinlock expert but shouldn't you use spin_unlock_irq()
> > when it was locked with spin_lock_irq() ?
>
> normally yes, but in this case it's an optimization: schedule() will
> disable interrupts within a few cycles, so there is no point in enabling
> irqs for a short amount of time.

Needs a comment.

-- 
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.."