Re: [PATCH] sd-many for 2.4.18-pre7 (uses devfs)

[Jens Axboe]

On Mon, Jan 28 2002, Richard Gooch wrote:
> Jens Axboe writes:
> > On Mon, Jan 28 2002, Richard Gooch wrote:
> > > Jens Axboe writes:
> > > > On Sun, Jan 27 2002, Richard Gooch wrote:
> > > > >   Hi, all. Appended is my sd-many patch. It supports up to 2080
> > > > > SD's. This patch is against 2.4.18-pre7, and is essentially the same
> > > > > as earlier versions of this patch, just compensating for kernel drift.
> > > > 
> > > > Could you please at least try to follow the style in sd? To me, this
> > > > alone is reason enough why the patch should not be applied.
> > > 
> > > ??? I *have* followed the style. Or at least I've tried to. Where did
> > > I not?
> > 
> > Are you serious?! You use

> +#ifdef CONFIG_SD_MANY
> +static inline int sd_devnum_to_index(int devnum)
> +{
> +	int i, major = MAJOR (devnum);
> +
> +	for (i = 0; i < sd_template.num_majors; ++i) {
> +	    if (sd_template.majors[i] != major)
> +		continue;
> +	    return (i << 4) | (MINOR (devnum) >> 4);
> +	}
> +	return -ENODEV;
> +}
> +#endif

Apart from this one hunk, yeah it looks consistent and much better now.

-- 
Jens Axboe