Re: [PATCH] Make ide-scsi compile in 2.5

Jens Axboe (axboe@suse.de)
Sun, 27 Jan 2002 11:49:43 +0100


On Sun, Jan 27 2002, Andi Kleen wrote:
>
> ide-scsi doesn't compile currently in 2.5.x. This patch fixes it in a
> rather hackish way by adding some kmap_atomic()s. It would be
> probably better to kmap earlier in process context in the request
> function instead, but I leave this to the people who know more
> about IDE/block layer than me (but apparently not compile ide-scsi..)

axboe@burns:~/src/linux> make drivers/scsi/ide-scsi.o
gcc -D__KERNEL__ -I/home/axboe/src/linux/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
axboe@burns:~/src/linux>

Works for me, what didn't compile?

Are you sure that you aren't hitting the sg address change? AFAICS,
there should not be a need for highmem mapping here. Requests coming out
of the block layer for /dev/scd* should be bounced for you, and sg
doesn't pass on highmem pages iirc.

Puzzled...

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/