Re: Possible Idea with filesystem buffering.

[Anton Altaparmakov]

At 11:31 20/01/02, Hans Reiser wrote:
>In version 4 of reiserfs, our plan is to implement writepage such that it 
>does not write the page but instead pressures the reiser4 cache and marks 
>the page as recently accessed.  This is Linus's preferred method of doing that.

But why do you want to do your own cache? Any individual fs driver is in no 
position to know the overall demands on the VMM of the currently running 
kernel/user programs/etc. As such it is IMHO inefficient and I think it 
won't actually work due to VMM requiring to free specific memory and hence 
calling writepage on that specific memory so it can throw the pages away 
afterwards but in your concept writepage won't result in the page being 
marked clean and the vm has made no progress and you have just created a 
hole load of headaches for the VMM which it can't solve...

The VMM should be the ONLY thing in the kernel that has full control of all 
caches in the system, and certainly all fs caches. Why you are putting a 
second cache layer underneath the VMM is beyond me. It would be much better 
to fix/expand the capabilities of the existing VMM which would have the 
benefit that all fs could benefit not just ReiserFS.

>Personally, I think that makes writepage the wrong name for that function, 
>but I must admit it gets the job done, and it leaves writepage as the 
>right name for all filesystems that don't manage their own cache, which is 
>most of them.

Yes it does make it the wrong name, but not only that it also breaks the 
existing VMM if I understand anything about the VMM (which may of course 
not be the case...).

Just a thought.

Best regards,

Anton

>Hans
>
>Shawn wrote:
>
>>I've noticed that XFS's filesystem has a separate pagebuf_daemon to handle
>>caching/buffering.
>>
>>Why not make a kernel page/caching daemon for other filesystems to use
>>(kpagebufd) so that each filesystem can use a kernel daemon interface to
>>handle buffering and caching.
>>
>>I found that XFS's buffering/caching significantly reduced I/O load on the
>>system (with riel's rmap11b + rml's preempt patches and Andre's IDE
>>patch).
>>
>>But I've not been able to acheive the same speed results with ReiserFS :-(
>>
>>Just as we have a filesystem (VFS) layer, why not have a buffering/caching
>>layer for the filesystems to use inconjunction with the VM?
>There is hostility to this from one of the VM maintainers.  He is 
>concerned that separate caches were what they had before and they behaved 
>badly.  I think that they simply coded them wrong the time before.  The 
>time before, the pressure on the subcaches was uneven, with some caches 
>only getting pressure if the other caches couldn't free anything, so of 
>course it behaved badly.
>
>>
>>
>>Comments, suggestions, flames welcome ;)
>>
>>Shawn.
>>
>>-
>>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>the body of a message to [e-mail]
>>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>Please read the FAQ at  http://www.tux.org/lkml/
>>
>
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [e-mail]
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/