> >> The following patch fixes compilation/miscompilation problems, which
> >> may happend iwtg variuos cross compile configuration, wherte the
> >> compiler used to compile the kernel does not necessarily define
> >> __linux__. The patch replaces __linux__ with __KERNEL__, using
>
> Adrian> Isn't this a compiler bug?
>
> Why would it be ? I may want to cross-compile from, e.g., NetBSD with
> the host compiler, or I may want compile from GNU/Linux, but with a
>...
If your compiler is configured as a cross-compiler everything should work
as expected. If you are trying to compile a Linux kernel with a gcc that
is configured to build binaries for NetBSD this sounds evil.
> >> __KERNEL_ as an indication that the source is compiled as a part of
> >> ...
>
> Adrian> This is definitely wrong in files that are not Linux-specific and that are
> Adrian> used on FreeBSD (and BSDI) as well (you would know that if you'd looked at
> Adrian> the files your patch changes)...
>
> *BSD define _KERNEL, don't they ?
I don't know (I never tried to compile a *BSD kernel).
But if yes please consider what the following parts of your patch change:
-#ifndef __linux__
+#ifndef __KERNEL__
> Regards,
> -velco
cu
Adrian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/