Re: [PATCH] Andre's IDE Patch (1/7)

[D. Hugh Redelmeier]

| From: Rob Radez <[e-mail]>

| This is the first of seven patches against 2.4.18-pre4, beginning the breakup
| of Andre Hedrick's IDE patch into smaller chunks.

I'm glad you are doing this, although I am ignorant of the politics.

I have an HPT366 that I have never used due to fear of drivers not in
the mainstream.

| diff -ruN linux-2.4.18-pre3/drivers/ide/ide-cd.h linux-2.4.18-pre3-ide-rr/drivers/ide/ide-cd.h
| --- linux-2.4.18-pre3/drivers/ide/ide-cd.h	Thu Nov 22 14:46:58 2001
| +++ linux-2.4.18-pre3-ide-rr/drivers/ide/ide-cd.h	Mon Jan 14 18:29:06 2002
| @@ -38,7 +38,9 @@
|  /************************************************************************/
| 
|  #define SECTOR_BITS 		9
| +#ifndef SECTOR_SIZE
|  #define SECTOR_SIZE		(1 << SECTOR_BITS)
| +#endif
|  #define SECTORS_PER_FRAME	(CD_FRAMESIZE >> SECTOR_BITS)
|  #define SECTOR_BUFFER_SIZE	(CD_FRAMESIZE * 32)
|  #define SECTORS_BUFFER		(SECTOR_BUFFER_SIZE >> SECTOR_BITS)

Being a chicken, I wonder if this would be better as:

   #define SECTOR_BITS 		9
  +#ifdef SECTOR_SIZE
  +#if SECTOR_SIZE != (1 << SECTOR_BITS)
  +#error SECTOR_SIZE != (1 << SECTOR_BITS)
  +#else
   #define SECTOR_SIZE		(1 << SECTOR_BITS)
  +#endif
   #define SECTORS_PER_FRAME	(CD_FRAMESIZE >> SECTOR_BITS)
   #define SECTOR_BUFFER_SIZE	(CD_FRAMESIZE * 32)
   #define SECTORS_BUFFER		(SECTOR_BUFFER_SIZE >> SECTOR_BITS)

Hugh Redelmeier
[e-mail]  voice: [phone]