Re: [PATCH] IBM Lanstreamer bugfixes

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 18 Jan 2002 21:35:19 +0000 (GMT)

> For #6, the udelay(1) had more to do with the following write() than
> with spin_lock(). When that delay was not there, the write failed
> randomly. The same with the udelay(10) at the end of the interrupt
> function...

That smells of covering up a race rather than fixing something. Another
thing you may be doing perhaps is hiding PCI posting effects ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/