Re: [PATCH] I3 sched tweaks...

[Justin Carlson]

--=-vP/TQ6GOqKKDDhDdkzHT
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2002-01-16 at 16:10, Robert Love wrote:
> On Wed, 2002-01-16 at 17:46, Ingo Molnar wrote:
>=20
> > we pass pointers across functions regularly, even if the pointer could =
be
> > calculated within the function. We do this in the timer code too. It's
> > slightly cheaper to pass an already existing (calculated) 'current'
> > pointer over to another function, instead of calculating it once more i=
n
> > that function. This will be especially true once we make 'current' a ti=
ny
> > bit more expensive (Alan's kernel stack coloring rewrite will do that i
> > think, it will be one more instruction to get 'current'.)
>=20
> Maybe we should benchmark it?  It is very easy to calculate current.
>=20
> Certainly I see the benefit if we start coloring the pointer (it adds 2
> instructions I believe) but let's make sure it is worth passing another
> 32-bit argument.  It could very well be, schedule_tick is called
> enough...

Don't forget that, in non-x86 land, current tends to be just kept in a=20
register.  No computations required.  Certainly passing it around on,
e.g. mips is a clear loss.

-Justin

--=-vP/TQ6GOqKKDDhDdkzHT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQA8Re5J47Lg4cGgb74RAkitAKDFhR51z42UJEtDYiZ/IMpQMLfajwCgtptp
YTfsmlvv+N6o+KzWjYA9qzo=
=bFaK
-----END PGP SIGNATURE-----

--=-vP/TQ6GOqKKDDhDdkzHT--