Re: [PATCH] Rx FIFO Overrun error found

Manfred Spraul (manfred@colorfullife.com)
Mon, 14 Jan 2002 17:32:02 +0100


This is a multi-part message in MIME format.
--------------4BF173CC46E0F51A0DF1DA90
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Jeff Garzik wrote:
>
> and it would be preferred to separate "add oom handling" and "fix nic
> hang" patches.
>
Attached is the patch against the nic hang. Now all rx error bits
trigger netdev_rx - it doesn't hurt and could catch further hardware
oddities.

--
	Manfred
--------------4BF173CC46E0F51A0DF1DA90
Content-Type: text/plain; charset=us-ascii;
 name="patch-natsemi-fifoonly"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch-natsemi-fifoonly"

--- 2.5/drivers/net/natsemi.c Fri Nov 23 20:35:23 2001 +++ build-2.5/drivers/net/natsemi.c Mon Jan 14 16:56:22 2002 @@ -1508,7 +1508,7 @@ if (intr_status == 0) break; - if (intr_status & (IntrRxDone | IntrRxIntr)) + if (intr_status & (IntrRxDone | IntrRxIntr | RxStatusFIFOOver | IntrRxErr | IntrRxOverrun )) netdev_rx(dev); if (intr_status & (IntrTxDone | IntrTxIntr | IntrTxIdle | IntrTxErr) ) {

--------------4BF173CC46E0F51A0DF1DA90--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/