Re: drivers missing __devexit_p in 2.4.18pre3

Keith Owens (kaos@ocs.com.au)
Mon, 14 Jan 2002 16:08:25 +1100


On Sun, 13 Jan 2002 20:07:34 -0700,
Erik Andersen <andersen@codepoet.org> wrote:
>A quick check of the source code shows that the following drivers
>appear to still be lacking the devinit fixes which are needed for
>the kernel to compile when using newer versions of binutils.
>
>Each of these files probably needs the following (though I'm too
>lazy to do it all myself, since my kernel doesn't use any of this
>stuff):
>
> s/remove:\(.*\)/remove:__devexit_p(\1)/g

Don't do that. You are blindly converting all remove entries to use
__devexit_p but __devexit_p should only be used when the function
itself is declared as __devexit.

I went through the entire kernel looking for uses of __devexit and
manually checked each reference to those functions, changing only the
functions that used __devexit. I might have missed one or two but I
guarantee that your list is wrong, picking three files at random, none
of them use __devexit.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/