Re: [2.4.17/18pre] VM and swap - it's really unusable

[Rusty Russell]

On Sat, 12 Jan 2002 12:23:09 -0800
Andrew Morton <[e-mail]> wrote:
> And guess what?   Nobody has tested the damn thing, so it's going
> nowhere.

Haven't had latency problems, to be honest.  Maybe I should start playing mp3s
while I code?

1) conditional_schedule?  Hmmm... Why the __set_current_state?  I think I prefer
   an explicit "if (need_schedule()) schedule()", with
   #define need_schedule() unlikely(current->need_resched)

2) I hate condsched.h: Use sched.h please!

3) Why this:
   > +#ifndef __LINUX_COMPILER_H
   > +#include <linux/compiler.h>
   > +#endif

Other than that, I like this patch.  Linus?
Rusty.
-- 
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.