Re: [PATCH] Fix fs/fat/inode.c when compiled with gcc-3.0.x

[Linus Torvalds]

On Fri, 11 Jan 2002, Tom Rini wrote:
>
> After talking with Franz Sirl abit (and reading the thread on the
> patch), the fix is in the gcc-3.1 branch (so gcc-3.1.0 will work), and
> the patch can be applied to 3.0.x

Ok.

> So should we workaround this now in 2.4.x or no?

I'll apply it to the 2.5.x tree - it's not as if it can hurt anything (it
will actually generate better code, as a signed divide is slightly more
complex than just a shift due to rounding issues, and gcc doesn't know
that the inode length will always be non-negative).

Whether it is worth working around in 2.4.x I don't have any real opinion
on, but I doubt it is worthwhile to compile 2.4.x with gcc-3.0.x anyway.
But again, applying it won't hurt.

		Linus