Re: Patch for ymfpci in 2.5.x

[Pete Zaitcev]

I am terribly sorry, but an additional fixup is needed,
as identified by Anders Rune Jensen (mental note - always
cc submissions to linux-kernel. So many good eyeballs).

--- linux-2.4.17-niph/drivers/sound/ymfpci.c.bak	Fri Jan 11 07:41:39 2002
+++ linux-2.4.17-niph/drivers/sound/ymfpci.c	Fri Jan 11 07:39:10 2002
@@ -832,7 +832,7 @@
 	u32 lpfK = ymfpci_calc_lpfK(rate);
 	ymfpci_playback_bank_t *bank;
 	int nbank;
-	unsigned le_0x40000000 = 0x40;
+	unsigned le_0x40000000 = cpu_to_le32(0x40000000);
 
 	format = (stereo ? 0x00010000 : 0) | (w_16 ? 0 : 0x80000000);
 	if (stereo)

Humbled
-- Pete

> Date: Fri, 11 Jan 2002 00:44:23 -0500
> From: Pete Zaitcev <[e-mail]>
> To: [e-mail]
> Cc: [e-mail], [e-mail]

> While 2.5.x was a bit unstable, ymfpci in 2.4 moved ahead a bit.
> Most of it is cleanup, but there is a real fix for artsd as well.
> ALSA is supposed to supersede this code, but unless it's happening
> tomorrow we better update it before the patch grows too big.
> 
> -- Pete
> 
> diff -ur -X dontdiff linux-2.5.2-pre11/drivers/sound/ymfpci.c linux-2.5.2-pre11-p3/drivers/sound/ymfpci.c
> --- linux-2.5.2-pre11/drivers/sound/ymfpci.c	Thu Jan 10 15:52:17 2002
> +++ linux-2.5.2-pre11-p3/drivers/sound/ymfpci.c	Thu Jan 10 21:17:13 2002
>[...]