Re: Big patch: linux-2.5.2-pre11/drivers/scsi compilation fixes

[Martin Dalecki]

Jens Axboe wrote:

>On Fri, Jan 11 2002, Adam J. Richter wrote:
>
>>	Today I plan to post patches to make everything in
>>linux-2.5.2-pre11/drivers/scsi compile, at least everything under
>>x86, compiled as modules.  They compile, and, the only undefined
>>symbol in when I boot is scsi_mark_host_reset in BusLogic.c.
>>However, the 2.5.2-pre11 patches are completely untested.
>>
>
>Please hang on with this for a week or so, there will be other changes
>to SCSI drivers required. You'll just end up doing the work twice.
>

For the record. We have a file called: sun3_NCR5380.c inside dirvers/scis.

There appers to be code there, which is using some of the oboslted error 
handling facilities.
But under a compilation switch, there is code for the new error 
management as well
already there, with some notes about the midlayer having problems.

If there is nobody supporting this driver, pleas consider switching 
those macros... the
oboslete stuff,won't compile anyway.

However I doubt, that sun3 is supported anyway at all... so if not, then 
please
consider this driver seriously  for total removal ftom the kernel soruce 
tree.

Here is the  actual cided code:

#if 1 /* XXX Should now be done by midlevel code, but it's broken XXX */
      /* XXX see below                                            XXX */

    /* MSch: old-style reset: actually abort all command processing here */

    /* After the reset, there are no more connected or disconnected commands
     * and no busy units; to avoid problems with re-inserting the commands
     * into the issue_queue (via scsi_done())

And later down:
#else /* 1 */

    /* MSch: new-style reset handling: let the mid-level do what it can */

    /* ++guenther: MID-LEVEL IS STILL BROKEN.
     * Mid-level is supposed to requeue all commands that were active on the
     * various low-l

Both are quite at the end of the file...