Re: [PATCH] suser to capable changes in char driver

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 11 Jan 2002 12:53:45 +0000 (GMT)

> * This tty is already the controlling
> * tty for another session group!
> */
> - if ((arg == 1) && suser()) {
> + if ((arg == 1) && capable(CAP_SYS_TTY_CONFIG)) {
> /*
> * Steal it away
> */

You can't allow stealing of the controlling tty as TTY_CONFIG, it gives you
direct access to fake input on that console so really wants to be rather
higher.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/