Re: bad patch in aic7xxx_linux.c

Nathan Myers (ncm-nospam@cantrip.org)
Thu, 10 Jan 2002 07:42:40 +0000


On Wed, Jan 09, 2002 at 01:20:46AM -0800, David S. Miller wrote:
> From: Nathan Myers <ncm-nospam@cantrip.org>
>> In patch-2.4.18-pre2, a nonsensical change was made in
>> linux/drivers/scsi/aic7xxx/aic7xxx_linux.c . While apparently
>> harmless, it suggests to me that you had intended to fold in an
>> entirely different patch, and "missed".
>
> Missed? That patch fixes a lethal bug.

Indeed, I missed that the value was also passed to ahc_linux_map_seg()
before being clobbered in the next statement.

> I don't find a current maintainer for aic7xxx listed in MAINTAINERS.
>
> It's listed in the aic7xxx sources, but the fix in question came to
> Marcelo via Jens Axboe.

One can guess, but there are no addresses for anyone noted there later
than 1999. In particular, Justin's address isn't listed.

I am interested in hotplugged aic7xxx (1480 CardBus). I will be posting
an Oops shortly related to that, unless somebody tells me not to bother.

Nathan Myers
ncm at cantrip dot org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/