Re: ALSA patch for 2.5.2pre9 kernel

Miles Lane (miles@megapathdsl.net)
07 Jan 2002 17:34:34 -0800


On Mon, 2002-01-07 at 10:00, Linus Torvalds wrote:
>
> On Mon, 7 Jan 2002, Alan Cox wrote:
> > > Or we could just have a really _deep_ hierarchy, and put everything under
> > > "linux/drivers/sound/..", but I'd rather break cleanly with the old.
> >
> > Christoph has an interesting point. Networking is
> >
> > net/[protocol]/
> > drivers/net/[driver]
> >
> > so by that logic we'd have
> >
> > sound/soundcore.c
> > sound/alsa/alsalibcode
> > sound/oss/osscore
> >
> > sound/drivers/cardfoo.c
> >
> > which would also be much cleaner since the supporting crap would be seperate
> > from the card drivers
>
> I would certainly not oppose that. Look sane to me, although the question
> then ends up being about "drivers/sound" or "sound/drivers" (the latter
> has the advantage that it keeps sound together, the former is more
> analogous to the "net" situation).

I like the layout proposed by Alan. All the other device-specific
drivers I use are under linux/drivers. Doing something else with
the sound drivers 1) breaks with the OSS layout, which we are
used to, and 2) would be an anomaly within the tree. Confusion
would definitely follow for newbie kernel builders and people
transitioning to 2.6, when it is released.

One additional change that might help make the nature of the
linux/net and linux/sound directories more obvious could be
to move them both into linux/system/. That way the hierarchy
indicates the purpose and similar nature of code in these
two directories.

Miles

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/