Re: [Ext2-devel] [PATCH 7/7 v2] Re: PATCH 2.5.2.9: ext2 unbork fs.h (part 1/7)

Andreas Dilger (adilger@turbolabs.com)
Mon, 7 Jan 2002 16:49:21 -0700


On Jan 07, 2002 18:28 -0500, Jeff Garzik wrote:
> --- linux-fs6/fs/ext2/ext2_fs_i.h Mon Sep 17 20:16:30 2001
> +++ linux-fs7/fs/ext2/ext2_fs_i.h Mon Jan 7 05:08:38 2002
> @@ -36,6 +36,10 @@
> __u32 i_prealloc_count;
> __u32 i_dir_start_lookup;
> int i_new_inode:1; /* Is a freshly allocated inode */
> +
> +#ifdef __KERNEL__
> + struct inode i_inode_data;
> +#endif
> };

Since ext2_fs_i.h only describes the in-memory data for ext2 inodes, there
is no reason to #ifdef __KERNEL__ any changes therein. I have seen several
other people worry about changes to this file in the past also, and I was
going to suggest adding a comment to the file, but I see it already says
"inode data in memory" so I don't know what else to add...

Cheers, Andreas

--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/