Re: [BUG] in 2.4.17 after 10 days uptime

[Marcelo Tosatti]

On Tue, 1 Jan 2002, Benjamin LaHaise wrote:

> On Tue, Jan 01, 2002 at 02:18:01AM -0500, Ed Tomlinson wrote:
> > I started getting these bugs after about 10 days uptime.  There is a patch 
> > set for reiserfs applied along with a few minor patches (ide-tape, disk 
> > stats for up to hdg).  The kernel is tainted by:
> 
> Expected BUG.  Here's the fix.  Marcelo, this is what we discussed previously: 
> parts of the kernel that grab a temporary reference to a page will frequently 
> not use page_cache_release as the page may never have been part of the page 
> cache.  This shows up with the network stack in sendpage() as well as many 
> other paths.  Please apply.

Ben, 

I suppose you're talking about the following case: 

pagecache code has LRU page

			    nonpagecache code does page_cache_get()

pagecache code does page_cache_release()

			   nonpagecache code does __free_pages_ok()
			   on LRU page: BOOM.	

Is my thinking correct ?

If so, I don't see why Ed's trace BUGs at rmqueue first: It should bug at
__free_pages_ok() PageLRU check.