Re: Patch?: linux-2.5.2-pre9/drivers/block/ll_rw_blk.c blk_rq_map_sg

Dave Jones (davej@suse.de)
Mon, 7 Jan 2002 14:02:24 +0100 (CET)


On Mon, 7 Jan 2002, Jens Axboe wrote:

> > The following patch removes gotos from blk_rq_map_sg, making
> > it more readable and five lines shorter. I think the compiler should
> > generate the same code. I have not tested this other than to
> > verify that it compiles.
> Well, I really think the original is much more readable than the changed
> version :-)

I agree. Upon seeing the patch, I was reminded of the monster
enormous conditional at http://gcc.gnu.org/projects/beginner.html
not quite _that_ bad, but getting there 8)

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/