Re: PATCH 2.5.2.9: fbdev kdev_t build fixes

[Adam J. Richter]

Jeff Garzik writes:
>This patch fixes the build for the rest of fbdev in 2.5.2-pre9...

        I submitted a patch two days ago that fixed drivers/video
compilation.  The difference between my patch and yours is that
while I deleted the initializations of the form "fb_info.node = -1;",
you replaced them with "fb_info.node = NODEV;".

        -1 is all ones, NODEV is currently encoded as all zeroes.
I see no change in your patch that modifies any test for the
value of the "node" field, so, if there was any test that relied
on this value, it is now broken.

        However, I believe that there is no test that relies on the
initial value of fb_info.node before any call to register_framebuffer
(which sets fb_info.node to something meaningful).  So, as far as I
can tell, these initializations of fb_info.node are just wasting
CPU cycles and confusing developers.

        Can anyone identify a place that uses the initialized value
of fb_info.node prior to fb_info.node being set by register_framebuffer?

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
[e-mail]     \ /                  San Jose, California 95129-1034
[phone]         | g g d r a s i l   United States of America
fax [phone]      "Free Software For The Rest Of Us."