Re: Serial Driver Name Question (kernels 2.4.x)

[Richard Gooch]

Andrew Morton writes:
> Richard Gooch wrote:
> > 
> > > Instead, it appears that someone broke tty_name().  Here's the
> > > 2.2 kernel's version:
> > 
> > That "someone" was me, and I changed it from broken to fixed.
> > 
> 
> Look at serial.c:
> 
> #if (LINUX_VERSION_CODE > 0x2032D && defined(CONFIG_DEVFS_FS))
>         serial_driver.name = "tts/%d";
> #else
>         serial_driver.name = "ttyS";
> #endif
> 
> tty_name will just print "ttyS".   So the transition for this case
> was fixed->broken.

Why exactly is just "ttyS" broken?

> > No, originally tty_name() did it, and then I shifted it to the
> > drivers. I don't recall the reason, but it was necessary. So I don't
> > want this changed.
> 
> Oh dear.  Why cannot devfs expand the minor part itself?

Do you mean why devfs can't do it, or do you mean why tty_name() can't
do it? As I said, tty_name() used to do it, but there was some problem
with that.

				Regards,

					Richard....
Permanent: [e-mail]
Current:   [e-mail]