Re: [PATCH]: 2.5.1pre9 change several if (x) BUG to BUG_ON(x)

[Alan Cox]

> Alan> 	BUG_ON(function(x,y))
> 
> #ifdef DEBUG
> #define BUG_ON(x) if (x) BUG()
> #else
> #define BUG_ON(x) (void)(x)
> #endif

(void)(x) may cause x not be evaluated if the compiler can optimise it out
on the grounds that the result is discarded. Fortunately gcc can't remove
anything that has side effects so providing there are no other bugs in the
code (eg referencing mmio addresses) it should be fine - you are correct