Looks sane - thanks. I see no harm in sending it to Linus. Could you run
the blkmtd.c changes past spse@secret.org.uk first, though?
> In the case of one routine (ftl_reread_partitions), there was a goto
> to a nonexistant label (goto leave), so I think there may have been an
> incomplete patch applied to this subdirectory to begin with
Not in my tree - strange. Oh well, I'll deal with it when 2.5 stabilises
and I stop ignoring it.
> (also, drivers/mtd/bootldr.c refers to a nonexistant "struct tag", but that
> file is apparently not currently compiled anyhow).
Currently, it's only compiled in the iPAQ kernel tree, where it works - I'm
waiting for the iPAQ people and Russell to stop arguing about how it should
be done, so the result will work in the proper ARM tree (and hence Linus'
tree) too.
Btw, where did you get the address 'mtd@infradead.org' from? The list moved
a while ago, and I was going to remove the forwarding some time soon.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/