Re: [CFT] Unbork fs.h + per-fs supers
Daniel Phillips (phillips@bonn-fries.net)
Sat, 5 Jan 2002 12:08:55 +0100
On January 5, 2002 10:54 am, Alexander Viro wrote:
> On Sat, 5 Jan 2002, Daniel Phillips wrote:
>
> > Adding VFS support for per-fs superblock size was dead simple compared to
> > doing the inodes because superblocks are few enough that no slab cache is
> > needed, and also because of cleanup Al had already done.
>
> *Stop*.
>
> First of all, exporting size of superblock is wrong, since the entire
> ->read_super() mechanism is going to be replaced with ->get_super(type, ...)
> (get_sb_...() becoming commonly used instances of the method). Moreover,
> freeing superblock is very likely to become a method (for quite a few
> reasons).
>
> Please, don't turn fs type into a bloody mess. It's bad enough as it
> is; at least don't add the stuff that will go away anyway.
How would you suggest it be done?
--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/