Re: Extern variables in *.c files
Andrew Morton (akpm@zip.com.au)
Wed, 02 Jan 2002 13:43:13 -0800
Oliver Xymoron wrote:
>
> On Wed, 2 Jan 2002, vda wrote:
>
> > I grepped kernel *.c (not *.h!) files for extern variable definitions.
> > Much to my surprize, I found ~1500 such defs.
> >
> > Isn't that bad C code style? What will happen if/when type of variable gets
> > changed? (int->long).
>
> Yes; Int->long won't change anything on 32-bit machines and will break
> silently on 64-bit ones. The trick is finding appropriate places to put
> such definitions so that all the things that need them can include them
> without circular dependencies.
>
Isn't there some way to get the linker to detect the differing
sizes?
-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/