Re: [PATCH] ide-probe does not set removable flag for ide-floppy devices

[Dave Jones]

On Thu, Dec 13, 2001 at 04:06:39PM -0700, Kevin P. Fleming wrote:
 > Small patch, relative to 2.4.17-pre8, but should apply to any recent version
 > 
 > diff -urN -X dontdiff linux/drivers/ide/ide-probe.c
 > linux-new/drivers/ide/ide-probe.c
 > --- linux/drivers/ide/ide-probe.c Wed Dec 12 11:01:24 2001
 > +++ linux-new/drivers/ide/ide-probe.c Sun Dec  9 11:41:15 2001
 > @@ -122,6 +122,7 @@
 >        printk("cdrom or floppy?, assuming ");
 >       if (drive->media != ide_cdrom) {
 >        printk ("FLOPPY");
 > +      drive->removable = 1;
 >        break;
 >       }
 >      }

<nitpick old mails time>
To me, this looks like it would make more sense to set this to 1 _before_
the switch statement, and set to 0 as necessary, as most of the cases
look removable to me. Should cut out a few lines of code, and also mark
things like ide-tape as removable in the process too. Or is this not
desired behaviour for some reason ?

Dave.

-- 
Dave Jones.                    http://www.codemonkey.org.uk
SuSE Labs.