Re: Ia64 unaligned accesses in ntfs driver

[Ville Herva]

On Mon, Dec 17, 2001 at 09:47:08AM +0000, you [Anton Altaparmakov] claimed:
> At 07:05 17/12/01, Ville Herva wrote:
> >I get unaligned accesses from these addresses:
> >
> >kernel unaligned access to 0xe00000006fb49719, ip=0xa000000000265050
> >
> >from ksymoops:
> >Adhoc a000000000265050 <[ntfs]ntfs_decompress+d0/320>
> >Adhoc a000000000262d80 <[ntfs]ntfs_decompress_run+2a0/3c0>
> >Adhoc a000000000262ba0 <[ntfs]ntfs_decompress_run+c0/3c0>
> >Adhoc a000000000262d60 <[ntfs]ntfs_decompress_run+280/3c0>
> >
> >Are these dangerous? I gather IA64 port has some kind of handler for these,
> >since they don't oops.
> 
> They are at least one of the explanations why the driver would not work on 
> non-intel arch... 

It does work (I _was_ surprised) on IA64. I can read the one ntfs partition
quite well. 

> I gather most other arch don't cope with unaligned accesses. I am
> surprised those are the only ones you see actually...

They are not the only ones, I haven't tracked all the entries in dmesg.
 
> This particular function is not implemented correctly anyway - it will not 
> work on BE arch for example (despite all the endian conversion functions, 
> some of which are wrong AFAIK).

I see.
 
> The changes to make the driver clean are too complex and I am not going to 
> bother considering the replacement ntfs driver (ntfs tng available from 
> linux-ntfs cvs on sourceforge) is close to being ready for inclusion into 
> 2.5.x (as soon as read support is completed I will submit it, probably 
> sometime in January). If anyone wants to work on the old driver I am happy 
> to take patches. (-;

Ok. I can give the new driver a shot on IA64 sometime, if I find the time.

-- v --

[e-mail]