Re: [PATCH] v2.5.1-pre9-00_kvec.diff

Benjamin LaHaise (bcrl@redhat.com)
Wed, 12 Dec 2001 16:24:12 -0500

On Tue, Dec 11, 2001 at 11:33:32PM +0000, Hugh Dickins wrote:
> Looks nice, but I think you need to update from atomic_inc(&map->count)
> and __free_page(map) to page_cache_get(map) and page_cache_release(map)?
> I haven't checked a 2.5.1-pre9 tree, but we had to change that in 2.4,
> to avoid PageLRU BUGs. page_cache_get end just tidiness, of course.

Hrm, the more I look at things, the more I'm convinced that this is wrong:
right now in the network code and other places we will use put_page() to
release a reference to a potential page cache page which could cause the
PageLRU BUG() to hit. I'm sure there are lots of subtle cases like this
all over the tree that the change in semantics has introduced bugs in.

-ben

-- 
Fish.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/