Re: CML2 1.9.6 is available

[Keith Owens]

On Wed, 12 Dec 2001 00:05:06 -0500, 
"Eric S. Raymond" <[e-mail]> wrote:
>Keith Owens <[e-mail]>:
>> One niggle, some strings for kuild 2.5 are longer than 30 characters,
>> cml2 restricts the string length in make menuconfig.  Only menuconfig
>> has this restriction, not oldconfig nor xconfig.  Can the limit be
>> removed, or at least changed to $ROWS-n which would adjust to screen
>> size?
>
>The only place I see a limit of 30 is in the query_popup function used
>for querying for things like search strings, symbol names in the go-to
>command, etc. in menuconfig.
>
>The answer is: maybe.  The underlying problem here is that the prompt
>string and the string editing area both eat screen width.  30 is about
>the largest limit that doesn't blow up the configurator when combined
>with the longest prompt strings.

This works for me.

--- cml2-1.9.6/cmlconfigure.py	Sun Dec  9 19:27:31 2001
+++ 2.4.16-kbuild-2.5/scripts/cmlconfigure.py	Wed Dec 12 17:23:01 2001
@@ -1009,7 +1009,7 @@
 
     def query_popup(self, prompt, initval=None):
         "Pop up a window to accept a string."
-        maxsymwidth = 30	# Constant
+        maxsymwidth = self.columns - len(prompt) - 2
         if initval and len(initval) > maxsymwidth:
             self.help_popup("PRESSANY", (lang["TOOLONG"],), beep=1) 
             return initval

Warning, that is my first bit of Python code (Oh no, now I'm
contaminated too :-).