Re: [PATCH] direct IO breaks root filesystem
Tachino Nobuhiro (tachino@open.nm.fujitsu.co.jp)
Wed, 12 Dec 2001 11:46:29 +0900
At Tue, 11 Dec 2001 17:46:01 -0800 (PST),
Linus Torvalds wrote:
>
>
> On Wed, 12 Dec 2001, Tachino Nobuhiro wrote:
> >
> > But my patch fixes another bug. Current /dev/ram* does not return -ENOSPC
> > at the end of device size because generic_file_write() also checks whether
> > mapping->host is a block device. So I think the patch is required.
>
> I'll agree with your one-liner: it's good practice anyway to initialize
> any fields that could ever be looked at. I actually already applied it to
> my tree, I just want to make sure that people don't apply the other
> patch..
>
> Linus
Thank you.
I think the patch should be applied to 2.4 because "dd if=/dev/zero of=/dev/ram1"
can cause system hang easily.
Marcelo, please consider applying the patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/