Re: [PATCH] fix for idiocy in mount_root cleanups.

[Linus Torvalds]

On Sat, 8 Dec 2001, Alexander Viro wrote:
>
> 	Change in question was s/do_mount/mount/.  Which is almost
> the same thing, except for one little detail:  mount(2) in case of
> error returns -1 and stores the error in errno.  do_mount(9), OTOH...

Don't use errno in the kernel. EVER. This is a bug, we should get rid of
it.

Please fix "mount()" instead.

"errno" is one of those few _really_ bad stupidities in UNIX. Linux has
fixed it, and doesn't use it internally, and never shall. Too bad that
user space has to fix up the _correct_ error code returning that the
kernel does, and turn it into the "errno" stupidity for backwards
compatibility.

(If you care why "errno" is stupid, just think about threading and
performance)

		Linus