Re: Some compiler warnings in 2.4.17-pre5

David Woodhouse (dwmw2@infradead.org)
Sat, 08 Dec 2001 09:47:56 +0000


bunk@fs.tum.de said:
> [both jffs2 and ppp have own copies of zlib]

They have identical copies of zlib, except for a typo fix in a comment in
the PPP version which was made after I copied it. It's probably worth
hacking the makefiles so that only one gets built and included.

In due course, the new zlib in fs/inflate_fs will get expanded to do
compression as well as decompression, and moved out of fs/ where it doesn't
really belong. At that point, JFFS2 and PPP can both use that.

You could prefix all the non-static symbols in either or both of these zlib
copies with 'ppp_' or 'jffs2_', but I prefer not to do that as it's just
hiding the problem, not fixing it.

--
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/