Re: Linux 2.4.17-pre4

[Tim Waugh]

--+vRq5lKQn39NaQ8P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 05, 2001 at 10:54:26PM +0100, Jakob Kemi wrote:

> Since 2.4.14 the ieee1284 parport functions have worked improperly
> for some drivers (CPiA, W9966 and others). Joe
> <[e-mail]> was quick to find the failure. He said he was
> going to send the patch to you some week ago and maybe he already
> have. If it somehow got lost in an internet black-hole or something
> I try to also send it to you. It's just a one-liner which reverts to
> pre-2.4.14 behavior.

I am the maintainer of this code.  Why is this the first time that I
have seen this patch (or even heard of a problem report)?  Marcelo,
please don't apply it.

The correct fix is to change:

ctl &= ~(PARPORT_CONTROL_STROBE | PARPORT_CONTROL_INIT);

so that it also turns off AUTOFD as well.

I have several patches queued up for parport (see
http://people.redhat.com/twaugh/patches/).  It would be very helpful
to me if you could first send changes to me rather than Marcelo or
Linus, so that merging is not made more difficult.  In addition, there
is a ChangeLog file in that directory; changing the code without
updating the ChangeLog makes my attempt to keep it current futile. :-(

Tim.
*/

--+vRq5lKQn39NaQ8P
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8Dp0kyaXy9qA00+cRAm62AKC3dA8TlEu0ZZSgd0HgIKka+omOJgCbB1yo
a0QxgOv+BNCNPiLOcM89Q+k=
=FnK/
-----END PGP SIGNATURE-----

--+vRq5lKQn39NaQ8P--