Re: [PATCH] 2.4.16: kmalloc tidying

[Alan Cox]

> +++ linux-2.4.16/drivers/sbus/char/envctrl.c	Tue Nov 13 05:31:02 2001
> @@ -897,10 +897,6 @@ static void envctrl_init_i2c_child(struc
>  		}
> =20
>                  pchild->tables =3D kmalloc(tbls_size, GFP_KERNEL);
> -		if (!pchild->tables) {
> -			printk("envctrl: Failed to get table, not enough memory.\n");

Why are you removing the checks here ?

>  	current->mm->rss =3D 0;
> -	setup_arg_pages(bprm); /* XXX: check error */
> +	retval =3D setup_arg_pages(bprm);
> +	if (retval)=20
> +		goto out_free_dentry;

At this point you need to do more drastic things - see the last -ac patch
for a possible solution