Re: Asm style

Ben Collins (bcollins@debian.org)
Wed, 21 Nov 2001 16:21:28 -0500

On Wed, Nov 21, 2001 at 11:07:03PM +0000, vda wrote:
> I'm using GCC 3.0.1 and seeing "multi-line literals are deprecated".
> Since a patch is necessary for that (and someone submitted it already)
> I'd like to hear from big kernel guys what asm statement style to use:
> asm(
> " cmd r,r\n"
> "lbl: cmd r,r\n"
> " cmd r,r\n"
> : spec
> : spec
> );
> [variable width for labels? I don't like it] or
> asm(
> " cmd r,r\n"
> "lbl: cmd r,r\n"
> " cmd r,r\n"
> : spec
> : spec
> );
> [better. But \n's are ugly] or
> #define NL "\n"
> asm(
> " cmd r,r" NL
> "lbl: cmd r,r" NL
> " cmd r,r" NL
> : spec
> : spec
> );

There's also:

asm("\
cmd r,r\n\
lbl: cmd r,r\n\
cmd r,r\n" : spec : spec);

Or something similar (the trailing "\" added for continuation). Probably
the easiest way to patch existing asm.

-- 
 .----------=======-=-======-=========-----------=====------------=-=-----.
/                   Ben Collins    --    Debian GNU/Linux                  \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/