Hmm.. It looks valid, but for the fact that the page lock is held. So
there's no way truncate_list_pages() can call "remove_inode_page()" on the
page, regardless of whether the page is on the LRU list or not.
That said, it might be cleaner to move the "lru_cache_add(page);" up to
before adding the page into the page cache - that way we add a new
invariant that just says "all pages in the page cache are on the LRU
list", which could be used for a few extra sanity checks, for example.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/