Re: VM-related Oops: 2.4.15pre1

[Andrea Arcangeli]

On Sat, Nov 17, 2001 at 07:12:51PM -0800, Linus Torvalds wrote:
> In article <[e-mail]> you write:
> >
> >I think this one liner (diffed against 2.4.14) could fix this Oops:
> 
> It really shouldn't matter - at that point we have the page locked, and

I also agree the patch shouldn't matter, but one suspect thing is the
fact add_to_swap_cache goes to clobber in a non atomic manner the page
lock. so yes, we hold the page lock both in swap_out and in
shrink_cache, but swap_out can drop it for a moment and then later
pretend to be the onwer again without a real trylock.

Andrea