Re: sbp2.c on SMP

[Kristian Hogsberg]

"H . J . Lu" <[e-mail]> writes:

> On Fri, Nov 16, 2001 at 05:15:47PM +0100, Kristian Hogsberg wrote:
> > This is true, but only because the struct list_head is the first
> > element in struct node_entry.  If it wasn't, lh would have been -16 or
> > so, as Andrew says.
> > 
> > In any case, it's the wrong fix, because the error is elsewhere:
> > neither the host_info list or the node list should contain NULL
> > entries.  This is just curing the symptoms.  HJ, could you provide
> > some details on the crash?  Do you have the sbp2 module loaded when
> > you insmod/rmmod ohci1394, and if so, does it crash without sbp2
> > loaded?
> > 
> 
> Found it. You have to use list_for_each_safe when you remove things.
> Here is a patch.

Thanks for looking into this, however these bugs have been fixed in
the cvs version of the drivers, except for the loop in video1394.c
(which wouldn't cause problems, since there's a break immediately
after the call to remove_card).

Kristian