Re: [PATCH] ppp_generic causes skput:under: w/ pppoatm andvc-encaps

David S. Miller (davem@redhat.com)
Wed, 14 Nov 2001 03:48:15 -0800 (PST)


From: Till Immanuel Patzschke <tip@internetwork-ag.de>
Date: Wed, 14 Nov 2001 12:13:10 +0100

that is - of course - a more pppoatm specific fix BUT my concern
ist that PPP requires (!) to have at least 2 bytes headroom [when
using PPP_FILTER] (which is NOT noted), and isn't it good practice
to check for room before claiming it?

Ignore my comments, I thought this was happening on output.
Yes, it seems ppp_generic should be verifying the headroom.

Franks a lot,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/