Re: [PATCH] parport_pc to use pnpbios_register_driver()

[Keith Owens]

On Sun, 11 Nov 2001 21:42:34 +0100 (CET), 
Kai Germaschewski <[e-mail]> wrote:
>linux/isapnp.h has the following code:
>
>---
>#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
> 
>#define __ISAPNP__
>---
>
>I believe the pnpbios driver should do things something similar. Users of 
>the interface should then only check for #ifdef __PNPBIOS__.
>
>The reasoning behind this is the following: When you have a driver 
>built-in, but pnpbios modular, the driver cannot use pnpbios 
>functionality. The above definition reflects exactly this.

Does this combination make sense?  If you are building a pnpbios driver
into the kernel then the configuration should force pnpbios support to
be built in as well.  We don't allow this combination for things like
scsi or ide, they require the common support to be built in if any
drivers are built in.  IMHO this problem should be fixed in .config,
not in driver source.